From 6521b5dc32d9bdc4d8826324cb7b2877910cc633 Mon Sep 17 00:00:00 2001 From: "Roberto E. Vargas Caballero" Date: Fri, 31 Jan 2014 17:30:00 +0100 Subject: Remove non defined behaviour in selcopy It is not defined when lateral effects of expressions are calculated, so an expression as: --last >= gp && !(selected(last - gp, y) is non portable. --- st.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/st.c b/st.c index c59bf1d..6e7077a 100644 --- a/st.c +++ b/st.c @@ -953,11 +953,12 @@ selcopy(void) { /* append every set & selected glyph to the selection */ for(y = sel.nb.y; y < sel.ne.y + 1; y++) { gp = &term.line[y][0]; - last = gp + term.col; + last = &gp[term.col-1]; - while(--last >= gp && !(selected(last - gp, y) && \ - strcmp(last->c, " ") != 0)) - /* nothing */; + while(last >= gp && !(selected(last - gp, y) && + strcmp(last->c, " ") != 0)) { + --last; + } for(x = 0; gp <= last; x++, ++gp) { if(!selected(x, y) || (gp->mode & ATTR_WDUMMY)) -- cgit v1.2.3-70-g09d2